This repository was archived by the owner on Nov 27, 2020. It is now read-only.
[2.6+] Removed AcmeDemoBundle #819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 What about 2.7 also? |
|
@Pierstoval 2.7 is included too. This PR is for any Symfony version higher than 2.6. |
|
This is not a bug fix, so surely it's not allowed into 2.6, and must go into 2.7+. |
|
@GrahamCampbell Symfony SE works in a different way than Symfony. The versions reflect the Symfony version for which SE is tied with. Nobody upgrades its Symfony SE, it's just a starting point for new projects. |
(the "default" firewall is now called "main")
|
👍 |
1 similar comment
|
👍 |
|
We're ready on the docs (a few spots still mention AcmeDemoBundle, but I don't think it's an issue). Can anyone think of any other side effects we haven't covered yet? Regardless, 👍 |
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Jun 11, 2015
This PR was merged into the 2.6 branch. Discussion ---------- [2.6+] Removed AcmeDemoBundle | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This removes the AcmeDemoBundle for Symfony Standard 2.6+. Commits ------- 42b1224 The security.yml file now uses the same configuration as in Symfony 2.3 (the "default" firewall is now called "main") eb4a8e1 Removed AcmeDemoBundle
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Aug 2, 2016
This PR was submitted for the 3.1 branch but it was merged into the 2.7 branch instead (closes #6796). Discussion ---------- Remove AcmeDemoBundle references After symfony/symfony-standard#819 and symfony/symfony-standard#818 last year the AcmeDemoBundle doesn't exist so having an article dedicated to it doesn't appear to make much sense. This adapts the article to be focused on removing 'a bundle'. Commits ------- 9476cfa Remove AcmeDemoBundle references
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the AcmeDemoBundle for Symfony Standard 2.6+.